Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,18 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Enable Corepack
run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: '22'
cache: yarn
- name: install dependencies
run: yarn install --frozen-lockfile --network-concurrency 1
run: yarn install --immutable
Comment thread
delthas marked this conversation as resolved.
- name: Prettier (changed files)
shell: bash
env:
BASE_REF: ${{ github.event.pull_request.base.ref }}
run: |
MERGE_BASE=$(git merge-base HEAD "origin/${BASE_REF}")
yarn run --silent prettier:diff --check "${MERGE_BASE}..HEAD"
yarn prettier:diff --check "${MERGE_BASE}..HEAD"
4 changes: 3 additions & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,16 @@ jobs:
exit 1
fi

- name: Enable Corepack
run: corepack enable
- name: Install NodeJS
uses: actions/setup-node@v6
with:
node-version: '24'
cache: yarn

- name: Install dependencies
run: yarn install --frozen-lockfile --prefer-offline
run: yarn install --immutable

- name: Build
run: yarn build
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tests-kmip.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Enable Corepack
run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: '22'
Expand All @@ -48,7 +50,7 @@ jobs:
working-directory: .github

- name: install dependencies
run: yarn install --frozen-lockfile --prefer-offline --network-concurrency 1
run: yarn install --immutable

- name: run kmip ClusterClient functional tests on pykmip
run: yarn ft_pykmip_test
Expand Down
32 changes: 23 additions & 9 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,30 +26,38 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Enable Corepack
run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'yarn'
cache-dependency-path: |
yarn.lock
lib/executables/pensieveCreds/yarn.lock
- name: install dependencies
run: yarn install --frozen-lockfile --prefer-offline --network-concurrency 1
run: yarn install --immutable
# Berry does not run `prepare` on install; some tests require build/.
- name: build
run: yarn build
- name: lint yaml
run: yarn --silent lint_yml
run: yarn lint_yml
- name: lint javascript
run: yarn --silent lint --max-warnings 0
run: yarn lint --max-warnings 0
- name: lint markdown
run: yarn --silent lint_md
run: yarn lint_md
- name: add hostname
run: |
sudo sh -c "echo '127.0.0.1 testrequestbucket.localhost' >> /etc/hosts"
- name: test and coverage
run: yarn --silent coverage
run: yarn coverage
- name: run functional tests
run: yarn ft_test
- uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
- name: run executables tests
run: yarn install && yarn test
run: yarn install --immutable && yarn test
working-directory: 'lib/executables/pensieveCreds/'

compile:
Expand All @@ -59,13 +67,15 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Enable Corepack
run: corepack enable
- name: Install NodeJS
uses: actions/setup-node@v4
with:
node-version: '22'
cache: yarn
- name: Install dependencies
run: yarn install --frozen-lockfile --prefer-offline
run: yarn install --immutable
- name: Compile
run: yarn build
- name: Upload artifacts
Expand All @@ -84,13 +94,17 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v6
- name: Enable Corepack
run: corepack enable
- name: Install NodeJS
uses: actions/setup-node@v6
with:
node-version: '24'
Comment thread
delthas marked this conversation as resolved.
cache: yarn
cache-dependency-path: tests/workflows/yarn.lock
- name: Install dependencies
run: yarn --cwd tests/workflows install --frozen-lockfile
run: yarn install --immutable
working-directory: tests/workflows
- name: Run workflow tests
run: yarn --cwd tests/workflows test
run: yarn test
working-directory: tests/workflows
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,11 @@ coverage/

# TypeScript
build/

# Yarn (Berry). Globbed, not anchored: the nested install roots are their
# own Yarn projects.
**/.yarn/*
!**/.yarn/patches
!**/.yarn/plugins
!**/.yarn/sdks
!**/.yarn/versions
16 changes: 16 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
nodeLinker: node-modules

# Yarn's default is an empty allowlist, which blocks every Git fetch.
approvedGitRepositories:
- 'https://github.com/scality/*'
- 'ssh://git@github.com/scality/*'

# Git dependencies with Yarn 1 lockfiles are bootstrapped by Yarn Classic,
# which corrupts its shared cache when run in parallel (YN0058). Droppable
# once those dependencies are on Berry.
networkConcurrency: 1

# Skip the one-day quarantine on new releases for our own packages.
npmPreapprovedPackages:
- '@scality/*'
27 changes: 15 additions & 12 deletions lib/executables/pensieveCreds/package.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
{
"name": "pensievecreds",
"version": "1.0.0",
"description": "Executable tool for Pensieve",
"main": "getPensieveCreds.js",
"scripts": {
"test": "mocha --recursive --timeout 5500 tests/unit"
},
"dependencies": {
"mocha": "5.2.0",
"async": "~2.6.1",
"node-forge": "^0.7.1"
}
"name": "pensievecreds",
"version": "1.0.0",
"description": "Executable tool for Pensieve",
"main": "getPensieveCreds.js",
"scripts": {
"test": "mocha --recursive --timeout 5500 tests/unit"
},
"dependencies": {
"async": "~2.6.4",
"node-forge": "^1.3.1"
},
"devDependencies": {
"mocha": "^12.0.2"
},
"packageManager": "yarn@4.18.0+sha512.fcb8716fe7cd0eece141ffc18b92193a9df9204c1ba83189c288835223fc0bbe64af473bab0d5e9927a7daeb5caf2bb07eb2787cc9338ca040ea125f2a1f2f7e"
}
Loading
Loading