Conversation
btdaad
force-pushed
the
improvement/RING-54773-reusable-rdma-actions
branch
5 times, most recently
from
September 21, 2026 12:55
a722dc8 to
db02c9d
Compare
The RDMA jobs in scality/ring repeat this SoftRoCE setup three times and derive the bind address inline. The action reports that address as an output instead.
btdaad
force-pushed
the
improvement/RING-54773-reusable-rdma-actions
branch
2 times, most recently
from
September 21, 2026 13:31
2454694 to
9d31d5a
Compare
Two RDMA jobs in scality/ring spawn a miniring the same way and poll its log for the same readiness line. Connector options pass through as one line each, so the sproxyd flags a caller needs stay in that caller's workflow. Stopping the cluster is left to the caller.
btdaad
force-pushed
the
improvement/RING-54773-reusable-rdma-actions
branch
from
September 21, 2026 14:00
9d31d5a to
3d22a99
Compare
btdaad
marked this pull request as ready for review
September 21, 2026 14:21
| - gcloud | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Very old version of checkout, should be update (v7 if i remember well)
btdaad
force-pushed
the
improvement/RING-54773-reusable-rdma-actions
branch
from
September 22, 2026 14:59
3d22a99 to
4ae327b
Compare
btdaad
force-pushed
the
improvement/RING-54773-reusable-rdma-actions
branch
from
September 22, 2026 15:02
4ae327b to
2075151
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: RING-54773
What
Two composite actions,
setup-rdma-runnerandstart-miniring, for the RDMA CI inscality/ring. Each ships with a test workflow of its own.Why
rdma-tests.yamlinscality/ringrepeats the SoftRoCE setup across itstest,test-bizioboxandperformancejobs, and spawns miniring the same way in two of them. Theperformancejob also derives the RDMA bind addressinline instead of reusing the one the setup already computed. The ring side (https://github.com/scality/ring/pull/7380) follows once this is tagged.
How
setup-rdma-runnertakes a netdev and a link name, installs the RDMA userspace tools, loadsrdma_rxe, recreates the link and outputs the netdev address.start-miniringspawns the cluster, polls its log for the readiness line and writes a pid file, with connector options passed one per line so a caller's sproxyd flags stay in the caller's workflow; teardown is the caller's, since a composite action cannot declare a post step.Testing
setup-rdma-runnerneeds a kernel that loadsrdma_rxe, so it runs on a self-hosted rocky9 runner, whilestart-miniringruns against a stub on a hosted one.