fix: treat already-fully-promoted target as success (idempotent) - #225
Merged
Merged
Conversation
When a workflow fails after a successful promote step, retrying the workflow caused the promote to fail with "target already fully promoted" because the target already had a .final_status. Treat this case as idempotent success so that workflow retries are not blocked by a promote that already completed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
LGTM |
Previously .final_status was copied as part of the regular batch. Since S3 lists objects lexicographically, files starting with '.' arrived first, meaning .final_status could be written to the target before all other artifacts were copied. A promote interrupted after that point would look fully promoted but be incomplete. Copy .final_status outside the main batch and only after all other objects have been successfully transferred. Its presence on the target now reliably means the promote completed in full. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes both issues:
Fixes PTFE-3537.
Behaviour
Test plan
🤖 Generated with Claude Code