Skip to content

fix: avoid shared mutable default args in GitHost helpers #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eve-ci-cd wants to merge 1 commit into from
Closed

fix: avoid shared mutable default args in GitHost helpers #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions bert_e/git_host/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@
self.data = data

@classmethod
def get(cls, client, url=None, params={}, headers={}, **kwargs):
def get(cls, client, url=None, params=None, headers=None,
**kwargs):
"""Get a Githost object.

The result is parsed using cls.GET_SCHEMA, of cls.SCHEMA if absent.
Expand All @@ -129,6 +130,8 @@
Returns:
The result of the query, parsed by the shema.
"""
params = {} if params is None else params
headers = {} if headers is None else headers
url = url or cls.GET_URL
if url is None:
raise InvalidOperation(
Expand All @@ -141,7 +144,8 @@
return obj

@classmethod
def list(cls, client, url=None, params={}, headers={}, **kwargs):
def list(cls, client, url=None, params=None, headers=None,
**kwargs):
"""List objects.

The result is parsed using cls.LIST_SCHEMA, or cls.GET_SCHEMA if
Expand All @@ -154,6 +158,8 @@
The elements of the response as they are parsed by the schema.

"""
params = {} if params is None else params
headers = {} if headers is None else headers

Check warning on line 162 in bert_e/git_host/base.py

View check run for this annotation

Codecov / codecov/patch

bert_e/git_host/base.py#L161-L162 

Added lines #L161 - L162 were not covered by tests
url = url or cls.LIST_URL
if url is None:
raise InvalidOperation(
Expand All @@ -180,8 +186,9 @@
return cls(**load_schema(schema_cls, data, **kwargs), _validate=False)

@classmethod
def create(cls, client, data, headers={}, url=None, **kwargs):
def create(cls, client, data, headers=None, url=None, **kwargs):
"""Create an object."""
headers = {} if headers is None else headers
url = url or cls.CREATE_URL
if url is None:
raise InvalidOperation(
Expand All @@ -196,8 +203,9 @@
return obj

@classmethod
def update(cls, client, data, headers={}, url=None, **kwargs):
def update(cls, client, data, headers=None, url=None, **kwargs):
"""Update an object."""
headers = {} if headers is None else headers

Check warning on line 208 in bert_e/git_host/base.py

View check run for this annotation

Codecov / codecov/patch

bert_e/git_host/base.py#L208 

Added line #L208 was not covered by tests
url = url or cls.UPDATE_URL or cls.GET_URL
if url is None:
raise InvalidOperation(
Expand Down
Loading