Replace asserts with explicit checks in APIEndpoint validation - #289
Closed
eve-ci-cd[bot] wants to merge 1 commit into
Closed
eve-ci-cd[bot] wants to merge 1 commit into
eve-ci-cd[bot] wants to merge 1 commit into
Conversation
asserts are stripped under python -O, silently disabling the class-definition sanity checks. Raise TypeError/ValueError instead.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
- Coverage 90.21% 90.18% -0.04%
==========================================
Files 82 82
Lines 11293 11296 +3
==========================================
- Hits 10188 10187 -1
- Misses 1105 1109 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APIEndpoint.__init_subclass__validated endpoint definitions withassert, which is stripped when Python runs with-O. This replaces them with explicitTypeError/ValueErrorraises carrying clear messages (class name, offending value). Behaviour is otherwise unchanged.Tests:
pytest bert_e/tests/test_server.pypasses (23), flake8 clean.