Skip to content

INTEGRATION [PR#6297 > development/9.4] CLDSRV-1002: format the whole codebase with prettier - #6298

Closed
bert-e wants to merge 10 commits into
development/9.4from
w/9.4/improvement/CLDSRV-1002/prettier-whole-repo
Closed

bert-e wants to merge 10 commits into
development/9.4from
w/9.4/improvement/CLDSRV-1002/prettier-whole-repo

Conversation

@bert-e

@bert-e bert-e commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

This pull request has been created automatically.
It is linked to its parent pull request #6297.

Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/9.4/improvement/CLDSRV-1002/prettier-whole-repo, please follow this
procedure:

 git fetch
 git checkout w/9.4/improvement/CLDSRV-1002/prettier-whole-repo
 # <amend or cancel the changeset by _adding_ new commits>
 git push origin w/9.4/improvement/CLDSRV-1002/prettier-whole-repo

Please always comment pull request #6297 instead of this one.

DarkIsDude and others added 7 commits September 21, 2026 14:43
Prettier now owns line length, so drop the eslint max-len rule it
conflicts with and the disable directives that went with it.

Issue: CLDSRV-1002
Generated with `yarn prettier:write`, no manual edit.

Issue: CLDSRV-1002
…-whole-repo' into w/9.4/improvement/CLDSRV-1002/prettier-whole-repo

# Conflicts:
#	lib/Config.js
#	lib/api/apiUtils/integrity/validateChecksums.js
#	lib/api/apiUtils/object/createAndStoreObject.js
#	lib/api/apiUtils/object/getReplicationInfo.js
#	lib/api/apiUtils/object/objectAttributes.js
#	lib/api/apiUtils/object/prepareStream.js
#	lib/api/apiUtils/object/storeObject.js
#	lib/api/apiUtils/object/validateChecksumHeaders.js
#	lib/api/apiUtils/quotas/quotaUtils.js
#	lib/api/bucketPutLifecycle.js
#	lib/api/completeMultipartUpload.js
#	lib/api/initiateMultipartUpload.js
#	lib/api/listParts.js
#	lib/api/objectCopy.js
#	lib/api/objectDeleteTagging.js
#	lib/api/objectGet.js
#	lib/api/objectGetAttributes.js
#	lib/api/objectPut.js
#	lib/api/objectPutCopyPart.js
#	lib/api/objectPutLegalHold.js
#	lib/api/objectPutPart.js
#	lib/api/objectPutRetention.js
#	lib/api/objectPutTagging.js
#	lib/routes/veeam/utils.js
#	lib/server.js
#	lib/utilities/collectResponseHeaders.js
#	lib/utilities/reportHandler.js
#	lib/utilization/scuba/wrapper.js
#	package.json
#	tests/functional/aws-node-sdk/test/bucket/putBucketLifecycle.js
#	tests/functional/aws-node-sdk/test/bucket/putBucketReplication.js
#	tests/functional/aws-node-sdk/test/object/objectCopy.js
#	tests/functional/aws-node-sdk/test/object/objectGetAttributes.js
#	tests/functional/aws-node-sdk/test/object/objectHead.js
#	tests/functional/aws-node-sdk/test/object/putVersion.js
#	tests/functional/backbeat/bucketIndexing.js
#	tests/functional/raw-node/test/routes/routeMetadata.js
#	tests/functional/raw-node/test/trailingChecksums.js
#	tests/functional/raw-node/utils/makeRequest.js
#	tests/functional/utilities/reportHandler.js
#	tests/multipleBackend/routes/routeBackbeat.js
#	tests/sur/quota.js
#	tests/sur/routeVeeam.js
#	tests/unit/Config.js
#	tests/unit/api/apiUtils/getReplicationInfo.js
#	tests/unit/api/apiUtils/integrity/validateChecksums.js
#	tests/unit/api/apiUtils/quotas/quotaUtils.js
#	tests/unit/api/apiUtils/validateChecksumHeaders.js
#	tests/unit/api/listMultipartUploads.js
#	tests/unit/api/multipartUpload.js
#	tests/unit/api/objectCopy.js
#	tests/unit/api/objectCopyPart.js
#	tests/unit/api/objectPut.js
#	tests/unit/api/objectReplicationMD.js
#	tests/unit/auth/TrailingChecksumTransform.js
#	tests/unit/routes/veeam-routes.js
#	tests/unit/utils/mpuUtils.js
#	tests/unit/utils/pushReplicationMetric.js
Prettier pads markdown table cells for alignment, which pushed this table
to 82 columns and tripped MD013. mdlint's config lives in the shared
Guidelines package and cannot be relaxed per repo, so shorten the widest
cell instead.

Issue: CLDSRV-1002
websiteHead.js and websiteHeadWithACL.js assert the ETag of index.html,
so reformatting these fixtures changes their MD5 and breaks the tests.
Their bytes are the test data, not source to style.

Issue: CLDSRV-1002

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.65204% with 348 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.49%. Comparing base (1bf89fa) to head (01719c4).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/management/configuration.js 24.24% 25 Missing ⚠️
lib/kms/wrapper.js 62.29% 23 Missing ⚠️
lib/management/index.js 17.85% 23 Missing ⚠️
lib/management/push.js 25.80% 23 Missing ⚠️
lib/api/objectGet.js 84.21% 21 Missing ⚠️
lib/api/apiUtils/object/objectLockHelpers.js 34.78% 15 Missing ⚠️
lib/management/credentials.js 7.14% 13 Missing ⚠️
lib/api/apiUtils/authorization/tagConditionKeys.js 63.33% 11 Missing ⚠️
lib/routes/routeWorkflowEngineOperator.js 15.38% 11 Missing ⚠️
lib/api/metadataSearch.js 47.36% 10 Missing ⚠️
... and 54 more
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/authorization/serviceUser.js 100.00% <ø> (ø)
lib/api/apiUtils/bucket/bucketShield.js 100.00% <100.00%> (ø)
lib/api/apiUtils/bucket/createKeyForUserBucket.js 100.00% <ø> (ø)
...api/apiUtils/bucket/getReplicationConfiguration.js 100.00% <100.00%> (ø)
...b/api/apiUtils/bucket/validateReplicationConfig.js 84.61% <100.00%> (-1.10%) ⬇️
lib/api/apiUtils/bucket/validateSearch.js 96.42% <100.00%> (ø)
lib/api/apiUtils/object/applyZenkoUserMD.js 80.00% <100.00%> (ø)
lib/api/apiUtils/object/checkHttpHeadersSize.js 88.88% <100.00%> (ø)
lib/api/apiUtils/object/checkReadLocation.js 100.00% <100.00%> (ø)
lib/api/apiUtils/object/checkUserMetadataSize.js 61.53% <100.00%> (-2.75%) ⬇️
... and 122 more
@@                 Coverage Diff                 @@
##           development/9.4    #6298      +/-   ##
===================================================
+ Coverage            86.46%   86.49%   +0.02%     
===================================================
  Files                  212      212              
  Lines                14580    14567      -13     
===================================================
- Hits                 12607    12599       -8     
+ Misses                1973     1968       -5     
Flag Coverage Δ
checksums-disabled-tests 35.34% <13.80%> (+0.01%) ⬆️
file-ft-tests 69.98% <69.89%> (-0.03%) ⬇️
file-ft-tests-null-compat 70.51% <69.99%> (+0.02%) ⬆️
kmip-ft-tests 28.10% <7.42%> (-0.01%) ⬇️
mongo-v0-ft-tests 71.13% <70.48%> (+<0.01%) ⬆️
mongo-v1-ft-tests 71.08% <70.48%> (-0.03%) ⬇️
multiple-backend 36.11% <20.33%> (+0.02%) ⬆️
s3c-ft-tests-v0 65.00% <65.60%> (-0.02%) ⬇️
s3c-ft-tests-v0-null-compat 65.06% <65.60%> (-0.04%) ⬇️
s3c-ft-tests-v1 64.98% <65.40%> (-0.02%) ⬇️
sur-tests 36.61% <16.84%> (-0.01%) ⬇️
sur-tests-inflights 39.44% <16.89%> (-0.01%) ⬇️
unit 74.18% <66.40%> (-0.04%) ⬇️
utapi-v2-tests 35.31% <14.60%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DarkIsDude and others added 3 commits September 21, 2026 15:42
These files do not exist on 9.3, so the cleanup that came with the
prettier switch never reached them. With max-len off they are unused
directives, and the strict lint step runs with --max-warnings 0.

Issue: CLDSRV-1002
GitHub reads .git-blame-ignore-revs automatically; locally it needs
git config blame.ignoreRevsFile .git-blame-ignore-revs

Issue: CLDSRV-1002
@DarkIsDude

Copy link
Copy Markdown
Contributor

Closing: parent PR #6297 is being retargeted to development/9.4.

@DarkIsDude DarkIsDude closed this Sep 23, 2026
@DarkIsDude
DarkIsDude deleted the w/9.4/improvement/CLDSRV-1002/prettier-whole-repo branch September 23, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants