bugfix(textarea): keep the same border width at rest, hover and focus - #1220
Merged
Merged
Conversation
Contributor
Hello cuervino,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
JeanMarcMilletScality
approved these changes
Sep 15, 2026
Contributor
Author
|
/approve |
Contributor
|
I have successfully merged the changeset of this pull request
Please check the status of the associated issue CUI-50. Goodbye cuervino. The following options are set: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CUI-50.
In Firefox a
TextAreais 2px wider and 2px taller at rest than on hover or focus, so the box shrinks and everything laid out below it jumps up by 2px as soon as the pointer arrives. Chromium is not affected.The component only declared
border-colorat rest, so the width and the style came from the browser default: 2px inset on Firefox, 1px solid on Chromium. Both:hoverand:focusset a full 1px border, hence the jump. Declaring the shorthand at rest makes the three states the same size everywhere, and replaces Firefox's inset relief with the flat border the theme intends.Measured in Firefox, 1440px window:
InputV2andInlineInputalready declare an explicit 1px solid border at rest, so this alignsTextAreawith the rest of the library.