feat(icon): add window-restore icon - #1224
Conversation
Hello hervedombya,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
a0fd554 to
2befb8a
Compare
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
Please check the status of the associated issue None. Goodbye hervedombya. |
TL;DR — Adds the FontAwesome window-restore glyph to the icon table so it can be used as
<Icon name="Window-restore" />.Context
Downstream apps need a "stacked windows / virtual machines" glyph that core-ui didn't expose yet. The Platform navigation in metalk8s currently inlines the SVG as a stopgap (scality/metalk8s#5127 — "inlined until core-ui ships this icon"). Shipping it here lets those apps drop the inline copy and use the shared component (with
withWrapper, sizes, theming, etc.).🔧 Usage
🔍 Review focus
iconTable.ts › 'Window-restore'— maps tofas faWindowRestore, which exists in@fortawesome/free-solid-svg-iconsand resolves through the existing dynamic import inIcon.component(no extra registration). The key follows the table's Capitalized-name convention.🧪 How to test
Render
<Icon name="Window-restore" />(e.g. in the Icon Storybook story): it shows the two-stacked-windows glyph, andsize/withWrapperbehave like any other icon, in both light and dark themes.🔗 References