Skip to content

feat(icon): add window-restore icon - #1224

Merged
bert-e merged 1 commit into
development/1.0from
improvement/window-restore-icon
Sep 22, 2026
Merged

bert-e merged 1 commit into
development/1.0from
improvement/window-restore-icon

Conversation

@hervedombya

@hervedombya hervedombya commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR — Adds the FontAwesome window-restore glyph to the icon table so it can be used as <Icon name="Window-restore" />.

Context

Downstream apps need a "stacked windows / virtual machines" glyph that core-ui didn't expose yet. The Platform navigation in metalk8s currently inlines the SVG as a stopgap (scality/metalk8s#5127 — "inlined until core-ui ships this icon"). Shipping it here lets those apps drop the inline copy and use the shared component (with withWrapper, sizes, theming, etc.).

🔧 Usage

<Icon name="Window-restore" size="2x" withWrapper />

🔍 Review focus

  • ⚪ iconTable.ts › 'Window-restore' — maps to fas faWindowRestore, which exists in @fortawesome/free-solid-svg-icons and resolves through the existing dynamic import in Icon.component (no extra registration). The key follows the table's Capitalized-name convention.

🧪 How to test

Render <Icon name="Window-restore" /> (e.g. in the Icon Storybook story): it shows the two-stacked-windows glyph, and size / withWrapper behave like any other icon, in both light and dark themes.

🔗 References

@bert-e

bert-e commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Comment thread src/lib/components/icon/iconTable.ts Outdated
@hervedombya
hervedombya force-pushed the improvement/window-restore-icon branch from a0fd554 to 2befb8a Compare September 21, 2026 12:32
@hervedombya

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e

bert-e commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue None.

Goodbye hervedombya.

@bert-e
bert-e merged commit dc160b1 into development/1.0 Sep 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants