Conversation
Contributor
Hello cuervino,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
…al states The Charts guideline was a stub: two short sections, a WIP placeholder and a TODO, no example. The library meanwhile ships four chart components and over fifty stories with no written rule, so nothing said which form to reach for or what the parts are called. Cover when a chart is the right tool and when a number, a ProgressBar or a table says it better, then name every part over two annotated diagrams, where hovering a numbered callout highlights the part it names. The anatomy follows what the components do rather than what a chart usually looks like, which corrected two things: the value axis sits on the right, and the unit belongs to the title since the ticks carry bare numbers. The three non-nominal states are rendered by the real Barchart rather than drawn, which is what made the gap visible: a query returning nothing draws a bare frame, with nothing to tell it apart from a failure. The section describes that behaviour as it stands.
Cuervino
force-pushed
the
improvement/CUI-55-chart-guideline
branch
from
September 21, 2026 14:23
30eb060 to
173ce83
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Charts guideline was a stub: two short sections, a WIP placeholder and a TODO, no example. The library ships four chart components and over fifty stories, and nothing said which form to reach for or what the parts are called.
When to use a chart, and when a number, a
ProgressBaror a table says it better. Plus the forms that read poorly, which is why none of them are in the library.Anatomy. Every part named over two annotated diagrams, the frame and the hover layer. Hovering a numbered callout highlights the part it names and spells it out under the diagram.
The anatomy follows what the components do rather than what a chart usually looks like, which corrected two things: the value axis sits on the right (
orientation="right"), and the unit belongs to the title sinceformatTickValueproduces bare numbers.Data terms and states. The three non-nominal states are rendered by the real
Barchart, not drawn. That is what made the gap visible: a query that returns nothing draws a bare frame, and nothing tells it apart from a failure. The section describes the behaviour as it stands rather than a target one.CUI-55