Bump synapse-api submodule to 2.5.0 (SpiketrainFrame), release 2.4.0 - #55
Merged
Merged
Conversation
Picks up the new synapse.SpiketrainFrame message, which the SpikeBinner node's tap publishes and nexus-desktop's binned-spike viewer decodes. package.json is left to release-please; src/api and dist are generated.
Points the submodule at 065ff8c (sciencecorp/synapse-api#84, merged). Bumps the package to 2.4.0 for a manual publish; release-please was removed in #51, so it will not do this.
namthor9
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
synapse-apisubmodule to065ff8c(sciencecorp/synapse-api#84, merged) to pick upSpiketrainFrame, refreshessrc/api_version.tsto 2.5.0, and bumps the package to 2.4.0.src/api/anddist/are generated byscripts/generate.sh, so the diff is just the submodule pointer and the two version strings.Testing
generate.shandbuild.shrun clean against the merged submodule. The generated types includeSpiketrainFrameandDisplayMap.jest: 4 suites, 40 tests pass. ASpiketrainFramewas round-tripped through encode/decode.After merging
Publish manually (
npm publish). release-please was removed in #51. nexus-desktop (sciencecorp/nexus-desktop#458) is waiting on 2.4.0.