Update ASV workflow in GitHub Actions - #9
Merged
Merged
Conversation
Replaced tox command with ASV installation and execution steps for benchmarking.
Member
|
What is the benefit of this? |
Member
Author
|
The action is failing right now, trying to debug https://github.com/scipp/scipp-benchmarks/actions |
Refactor ASV benchmark steps in CI workflow to use a named step for clarity.
Removed PYTHONPATH environment variable from ASV benchmarks step and added installation command for scipp.
Removed ASV benchmark steps and replaced with editable tox environment.
Replace tox commands with ASV benchmark commands and install requirements.
Removed working-directory from ASV benchmarks step.
Member
|
Is this ready for review? |
MridulS
marked this pull request as draft
January 28, 2026 11:15
Member
Author
|
No not yet. Turned into a draft. |
MridulS
marked this pull request as ready for review
September 9, 2026 07:34
Member
Author
|
The run is happy now https://github.com/scipp/scipp-benchmarks/actions/runs/34243396541 I'll self merge this and see how this works out, I have changed the frequency to daily for the runs for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced tox command with ASV installation and execution steps for benchmarking.