Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a segfault I've stumbled upon when clicking OK in the Ship Initial Status dialog with more than one ship selected.
Cause
ShipInitialStatusDialogModel::initializeData()only sets up_numDockPointsand_dockpointArraywhen editing a single ship. In multi-edit mode_numDockPointswas left uninitialized (garbage value) and_dockpointArraystayed null.apply()still calledupdateDockingInfo(), which then indexed the null array.Changes
_numDockPoints(and_multiEdit) default initializers so the multi-edit state is well defined.updateDockingInfo()inapply()when editing multiple ships, since docking is only editable for a single ship.updateDockingInfo()that returns early if there is no dock point data.Testing
updateDockingInfo).Additionally I noticed a triple copy-paste where the shield and hull "blank field" checks tested
vflagthree times instead of hflag, sflag. I assumed that wasn't intentionally, so correct me on this one.Here's the backtrace using GDB if its of any use:
backtrace.txt