Repository navigation
Conversation
afterburners_start()/afterburners_stop() timed the +Aburn Cooldown Time delay and the player's 1.3 s re-engage delay with timer_get_milliseconds(), the real clock. Under time compression a cooldown therefore lasted longer in mission time than the table says, and it kept running while the game was paused. The cooldown was added in 2020 and reused the retail re-engage check's real-clock "now"; the rest of the file (ABURN_DECAY_TIME, the sound timers) already uses mission timestamps. Both delays now use the mission clock. The mission clock does not run outside missions, so it can still be near zero when the first mission of a session starts; the "last stopped" and "last started" times therefore start out invalid instead of 0, so that no delay is in effect before the afterburner has been used. Without time compression or pausing, the delays behave as before.
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #7874; as suggested there, this applies in all modes, not only headless runs.
+Aburn Cooldown Timeand the player's 1.3 s afterburner re-engage delay were timed withtimer_get_milliseconds(), the real clock. Under time compression a cooldown therefore lasted longer in mission time than the table says, and it kept running while the game was paused. The cooldown was added in 2020 (23f8062) and reused the retail re-engage check's real-clocknow; the rest ofafterburner.cppalready uses mission timestamps.Both delays now use mission timestamps. The mission clock does not run outside missions and can be near zero when a session's first mission starts, so the "last stopped" and "last started" times start out invalid instead of 0; no delay applies before the afterburner has been used.
Behaviour change: only under time compression or a pause. At 1x the delays are unchanged.
Testing: a ship with
+Aburn Cooldown Time: 4and an AI "afterburn hard" goal, windowed, gap from each afterburner stop to the next engage, in mission time:The ship afterburns within 3 s of mission start, so the first mission does not start in cooldown. Builds alone on this branch.