Repository navigation
Conversation
The game pauses when its window loses focus. With in-game options on, that is governed by the Game.UnfocusedPause option (default on), and the legacy -no_unfocused_pause flag is ignored, as other legacy flags are. An unattended run started with -noninteractive therefore stopped as soon as another window was in front, for example when several test instances run side by side. -noninteractive means nobody is at the keyboard to resume the game, so pause_if_unfocused() now returns false for it. This covers all three focus paths (game_poll, game_pause, game_unpause). Interactive runs are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game pauses when its window loses focus. With in-game options on, that is governed by the
Game.UnfocusedPauseoption (default on), and the legacy-no_unfocused_pauseflag is ignored, as other legacy flags are. A run started with-noninteractivetherefore stops as soon as another window is in front, for example when several automated test instances run side by side, and nobody is there to unpause it.-noninteractivealready means nobody is at the keyboard, sopause_if_unfocused()now returns false for it. That covers all three focus paths (game_poll,game_pause,game_unpause). Interactive runs are unchanged, and the option still takes precedence over the legacy flag.Testing: four windowed
-noninteractiveinstances side by side with the option at its default: before, the background windows paused (GS_EVENT_PAUSE_GAMEin the log); after, all ran to the end at full speed with no input.