Skip to content

Fix media generate --no-progress option registration - #12

Merged
nxtman123 merged 1 commit into
mainfrom
fix/media-generate-no-progress
Sep 10, 2026
Merged

nxtman123 merged 1 commit into
mainfrom
fix/media-generate-no-progress

Conversation

@nxtman123

Copy link
Copy Markdown
Collaborator

media generate --no-progress was rejected as an unsupported option even though the generation handler already supports suppressing its stderr notice. Register the option on the native command so it is accepted and appears in help.

Add an invocation-level regression test that verifies successful generation, an unchanged request payload, returned media and usage, and empty stderr. The existing progress test verifies that ordinary invocations still emit the notice.

Validation:

  • The new regression failed with exit 2 before the fix.
  • Build, typecheck, lint, public repository check, and mock smoke test passed.
  • Media generation, Commander, and help tests passed: 32/32.
  • Package dry run passed (402 files); command help includes the option.
  • git diff --check passed.
  • Local vendor checking remains blocked by a pre-existing mismatch between the bundled SDK and the sibling backend's generated SDK; no vendor files changed. The full npm test gate was not rerun because it starts with that check.

Dependency reinstallation, release packaging, npm installation, and live-server/plugin/player gates were not run for this focused command-registration change.

@nxtman123
nxtman123 merged commit 8f2c1b8 into main Sep 10, 2026
6 checks passed
@nxtman123
nxtman123 deleted the fix/media-generate-no-progress branch September 10, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant