Repository navigation
Align CLI with primitive and selector vocabulary - #2
Merged
Merged
Conversation
Co-authored-by: Gersham Meharg <gersham@users.noreply.github.com>
Co-authored-by: Gersham Meharg <gersham@users.noreply.github.com>
Co-authored-by: Gersham Meharg <gersham@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
media list --kindwith--primitive, reject the retired media flag, and send theprimitiveparameterprimitives[]with a flattenedprimitivefieldby:id|ids|all|tag), while iframe/application primitives reject selectors and retired top-level selection fieldsby:id/by:ids, and rename application event output toprimitive_idContract follow-up
The backend OpenAPI snapshot pinned in
vendor/still contains the pre-changekind,placements, nestedcontent, resolveditems, andplacement_idvocabulary. This PR deliberately does not sync or hand-edit generated vendor inputs: the backend primitive-shape PR is still in flight, and the vendored snapshot must be refreshed from that reviewed backend checkout once it lands. The CLI implementation here already emits the target wire names rather than claiming compatibility with the stale snapshot.Verification
Passed on the final revision:
npm ci(0 vulnerabilities)npm run check:publicnpm run vendor:check(internal snapshot consistency only)npm run typechecknpm run lintnpm test(347 tests: 346 passed, 1 skipped, 0 failed)npm run smoke:mocknpm run pack:dry(229 files, 241.7 kB packed / 1.1 MB unpacked)npm run pack:release(13 exact runtime dependencies; artifact check passed)npm run check:npm-installFinal
screenrig-cli.tgzSHA-256:8ca6feca8e9c8053fe16e033d68d6c5feef00de995923d59c8d19205f51c5e03.A stale-vocabulary scan across non-generated TypeScript and Markdown found no old
placements, nestedcontent.type/content.selector,wire_kinds, media--kind image,placement_id, or resolved-itemslanguage. The only legacy playlist vocabulary is in the pinned generated vendor snapshot and tests explicitly identifying that snapshot.Not run:
npm run smoke:server(requires an owned backend already serving the new wire),npm run vendor:check:drift(no reviewed backend checkout), live plugin/player/native/browser playback, npm publication, or deployment.Scope
Do not merge yet. No npm publish, plugin bundle update, backend dispatch, player change, or deployment.