Repository navigation
Reject invalid CLI arguments before side effects - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsupported options could previously be ignored while a mutation proceeded:
screen update ... --dry-runsent a PATCH,screen list --name Lobbyreturned an unfiltered list, and extra positionals or malformed numeric options could be silently discarded.Add a shared command catalog, reject unknown/duplicate/missing-value options during parsing, and validate command-scoped options, positional counts, numeric values, revisions, and incompatible options before configuration or transport access. Preserve supported aliases, help paths, zero-timeout semantics, and empty K/V byte payloads. Error messages do not repeat arbitrary option names or values.
Validation: public check, vendor integrity and backend drift check, typecheck, lint, and dry packaging passed. Full suite: 551 passed, 5 failed because Liberation Serif is unavailable on this host, 1 skipped; CI installs the required fonts. Includes 24 new validation tests and updates three tests that previously expected ignored options. Release artifact validation (18 exact runtime dependencies), clean npm installation, and mock smoke also passed. All five CI checks passed; distribution is correctly skipped for this pull request. No vendor inputs changed. Live-server, plugin, and Player checks were not run for this CLI-only change.