Repository navigation
Allow commander in bundled CLI production dependencies - #5
Merged
Merged
Conversation
CLI main now declares commander after the parser move. Keep the public gate exact-set check, add commander only, and regenerate the plugin from current screenrig/cli main so the committed bundle matches. Co-authored-by: Gersham Meharg <gersham@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
screenrig/climain now uses Commander (cli#7). Public plugin gates fail after packing that CLI:cli#10already restored flat leaf paths in root--help, so skill-vs-binary is not the blocker.Change
commanderto the exact production-dependency allowlist inscripts/check-public-repo.py. The set remains closed:@napi-rs/canvas,ajv,ajv-formats,commander.scripts/test-public-dependencies.pyand reject a missingcommanderdeclaration.plugins/screenrig/from currentscreenrig/climain and record provenance incomponents.lock.json.Verification
Local public gates passed on this revision:
python3 scripts/check-public-repo.pyplugins/screenrig/skills/screenrig/scripts/screenrig --json versionpython3 scripts/build-plugin.py --check --cli-artifact <packed-cli-main>python3 scripts/validate-plugin.py --cli-artifact <packed-cli-main> --cli-source <cli-main>(includes stale-language audit)python3 scripts/test-public-dependencies.py(8 tests)python3 scripts/test-skill-commands.pypython3 scripts/test-plugin-freshness.pypython3 scripts/test-launcher.pyBundled CLI:
screenrig/cli6b85d88e478b827cb3d8ba453a17625ff14b74ca, artifact sha256bee8279b52401f006c0b69fae8b7aaace1ae7b6764d425d81c83b2069c25dc9c.Skipped: marketplace install, live API, native hardware, production deployment.