Repository navigation
Fix/update at - #105
Merged
Merged
Fix/update at#105
Conversation
andrewtavis
approved these changes
Oct 5, 2026
andrewtavis
left a comment
Member
There was a problem hiding this comment.
praise: This all looks great and makes total sense, @DeleMike! Thanks for deriving the issue here and sending along the fix! 😊
Member
Author
|
Thanks! I will now run the process :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./pre-commitexecutable as well asmake lintand have fixed all reported issuesDescription
This PR fixes the issue as stated in #104.
Old data backups on Toolforge are removed. Each deployment moves the current SQLite packs into a
packs/sqlite.backup.<date>folder, and these were never deleted. The deploy step now keeps only the two most recent backups, so there's always the one just made plus one older for a rollback.updated_atnow matchesdata-version. Scribe-Server always setupdated_atin theGET /api/v1/data/{lang}response to the date of the API request. This was set during my initial development of the API.GET /api/v1/data-version/{lang}already has the correct dates, which client apps can ping to know whether they need to get new data. This PR setsupdated_atto the most recent of thosedata-versiondates, so both endpoints agree.For example, for English:
data-version: nouns2026-09-30, verbs2026-09-28, profanity2026-10-01updated_at:2026-10-01(previously the date of the request)Testing
database/versions_test.go).updated_atmatches the newestdata-versiondate foren,deandru.packs/sqliteisn't touched.Related issue
updated_atis always the request date, and Toolforge keeps every data backup #104