Fix numba JIT disable patch targeting wrong config attribute - #1181
Conversation
Test suite tried to force-disable numba JIT when already imported by patching `NUMBA_DISABLE_JIT` on numba.core.config, but numba internally reads the env var into an attribute named `DISABLE_JIT` (no prefix). We should find a less hacky solution to this, but for now, running the tests sequentially (`pytest -x`) always pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 52 52
Lines 7874 7874
=======================================
Hits 7277 7277
Misses 597 597 🚀 New features to boost your workflow:
|
|
|
|
Thanks for the fix, well spotted!
Yes, clean solution is to fix it in another PRs, but practically those pre-commit fail happen routinely so we usually just address them at the first occasion (or sometimes merge to main with red CI and fix it later, if we know that we are going to fix it soon anyway). I fixed it here right before merging: #1180. |
Test suite tried to force-disable numba JIT when already imported by patching
NUMBA_DISABLE_JITon numba.core.config, but numba internally reads the env var into an attribute namedDISABLE_JIT(no prefix).We should find a less hacky solution to this, but for now, running the tests sequentially (
pytest -x) always pass.