Repository navigation
Switch the Pages source to this workflow before deploying - #87
Merged
Merged
Conversation
The first deployment went green without changing the live site. The repository builds Pages from a branch, so Jekyll kept rendering README.md at seanwevans.github.io/pg_shell/ while actions/deploy-pages created a deployment and reported success against it. Nothing in the run says the site is unchanged, which is the worst version of this failure. actions/configure-pages only chooses the source when it creates the site, so an already-enabled repository stays on its branch build. Set build_type explicitly instead, using the pages: write permission the job already holds, and fail with the exact setting to change if the API refuses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H8iHRyutFShXsSLQ2wSQe5
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first Pages deployment (#86) went green without changing the live site.
The repository was building Pages from a branch, so Jekyll kept rendering
README.mdat https://seanwevans.github.io/pg_shell/ whileactions/deploy-pagescreated a deployment against it and reported success. Nothing in the workflow run said the site was unchanged, which is the worst version of this failure: a green check and a stale site.actions/configure-pagesonly chooses the source when it creates the Pages site. On a repository where Pages is already enabled it reads the existing config and moves on, leaving the branch build in place.Change
One step in
.github/workflows/pages.yml, betweenconfigure-pagesand the artifact upload, that setsbuild_typeexplicitly using thepages: writepermission the job already holds:workflow→ no-opPUT /repos/{owner}/{repo}/pageswithbuild_type=workflowThe source is set correctly on this repository now (changed by hand), so this is a guard: it keeps a future flip from silently going green, and makes the workflow self-sufficient for anyone forking the repo.
Testing
The YAML parses and the inline script passes
bash -n. The behaviour it guards against is what was observed on run 33911724911 — build and deploy both green,Reported success!,Evaluated environment url: https://seanwevans.github.io/pg_shell/, andcurlstill returning the Jekyll build.No application code changes, so CI coverage is unchanged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01H8iHRyutFShXsSLQ2wSQe5
Generated by Claude Code