Allow ruleset tables to be passed to legacy functions.#87
Merged
Conversation
HaroldCindy
requested changes
Jul 13, 2026
HaroldCindy
left a comment
HaroldCindy
left a comment
Contributor
There was a problem hiding this comment.
Few comments, general idea looks good but the tests could be made more concise
| slua_ruleset_serialize(L, params_idx, def); | ||
|
|
||
| // Replace original table with serialized list | ||
| lua_replace(L, params_idx); |
Contributor
There was a problem hiding this comment.
Since this function allows pseudo-indices, automatically calling lua_replace() on params_idx internally may not always be what you want (for ex. with upvalues and whatnot.) Maybe not a problem in practice but something to keep in mind.
HaroldCindy
approved these changes
Jul 14, 2026
HaroldCindy
left a comment
HaroldCindy
left a comment
Contributor
There was a problem hiding this comment.
lgtm, just chop off the comments that are likely to get stale
| #include "llsl.h" | ||
| #include "llruleset_builder.h" | ||
|
|
||
| #include "lapi.h" // luaA_toobject, luaA_pushobject |
Contributor
There was a problem hiding this comment.
These comments aren't necessary or idiomatic, one can see on mouse hover where a symbol is defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the ruleset tables to be use in the legacy functions, and removes llhttp:request
Issue secondlife/lsl-definitions#175
related PRs:
secondlife/lsl-definitions#177
https://github.com/secondlife/server/pull/2574