Repository navigation
Membership data (organization, dates) and Celery renewal reminders - #169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Membership.started/untilbecome dates. Membership runs one year from joining; renewing early extends from the current end date. Both dates are editable in the admin. Existing rows migrate tountil = Dec 31 of the stored yearandstarted = paid date of the linked payment, else Jan 1 of the stored year(verified forwards and backwards on a 0024-shaped SQLite).organizationandorganization_typeonMembership, required on the application form. Existing members with a membership are redirected once to/membership/detailsto fill them in (admin, SSO gateway, payments and the apply form are exempt).MembershipReminderso nothing goes out twice. Honorary members and members with a pending renewal invoice are skipped.manage.py send_membership_reminders --dry-runpreviews what would be sent.RegistrationOption.membership_end_yearbecomesmembership_until(date);Payment.mark_paidstill accepts the legacy key present in already-stored payment data.deployment.md.Note:
conftest.pyenv defaults do not reach import-time settings because pytest-django imports settings first; the Celery test configuration is therefore applied inpytest_configureon the settings object. The pre-existingEvent.descriptionmigration drift is untouched.Test plan
uv run pytest: 73 passed locally, new modules at 100% coverage)manage.py send_membership_reminders --dry-runlists the expected members; first automated wave is 2026-11-01 for memberships ending 2026-12-31/membership/detailsonce and lands on the profile afterwards