Skip to content

A differing pair can print "1.00", exactly like an agreeing one #28

Open

Description

@mklarmann

Found in the review of PR #20 (sentier-bafu-agribalyse, 17 Nov 2026). Line numbers are at 7274efd.

A grid cell shows the ratio in three digits. Pairs at ×1.0002 and ×1.004 that the rule classes "differs" both print "1.00", the same text as an agreeing pair. Only a tint of about 14 % (ratioView, diagnostics.js:276-285) and the tooltip tell them apart, so colour is the only thing that carries the difference. On a step 0 (a reproduction), most of the grid is like this.

ratioText already writes a ratio near 1 as "1 + 3e−7". Fix: a pair that is not "agrees" never prints text that also reads as an agreeing pair: use ratioText's form wherever three digits round to 1, and test that a differing ×1.0002 does not print "1.00".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions