Skip to content

An indicator called "name" or "worst" collides with the grid's sort keys #29

Open

Description

@mklarmann

Found in the review of PR #20 (sentier-bafu-agribalyse, 17 Nov 2026). Line numbers are at 7274efd.

The grid's sort keys share one space with indicator ids (diagnostics.js:784-785, 816, 834), and the format allows any id. With an indicator called name, clicking its heading sorts by item name and marks both columns as sorted. With worst, that column can never be sorted and starts out marked as sorted.

Fix: keep the page's own sort keys apart from indicator ids (for example {by: 'indicator', id} against {by: 'name'}), and test with indicators called name and worst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions