Skip to content

Host styles leak into the page: buttons, list bullets, and dark ink on a dark host #30

Open

Description

@mklarmann

Found in the review of PR #20 (sentier-bafu-agribalyse, 17 Nov 2026). Line numbers are at 7274efd.

Nothing leaks out of the page (every selector starts with .sentier-diagnostics, there are no element ids, and the only global is SentierDiagnostics), but host styles leak in:

  • measured: a host rule button {min-height: 44px; text-transform: uppercase} makes the headings and chips 44 px tall and upper-case;
  • measured: li::before {content: "• "} adds bullets in "Why it differs";
  • from reading: on a dark host without the Sentier tokens, the fallback ink colour (diagnostics.css:9, 33) gives dark text on a dark ground.

Fix: reset the properties the page relies on for its own elements (all: revert-style resets on buttons and lists inside the root, or explicit values), take the ground colour together with the ink so a fallback is never dark on dark, and test with a hostile host style sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions