Skip to content

A breakdown fetched over http is checked by its ids only, not by its totals #33

Open

Description

@mklarmann

Found in the review of PR #20 (sentier-bafu-agribalyse, 17 Nov 2026). It predates #20. Line numbers are at 7274efd.

A breakdown the page fetches over http is checked by its item and state ids only (diagnostics.js:1078-1084), not by its totals, as breakdown.against does in Python. A breakdown of another run with the same ids is drawn as this file's.

Fix: hold a fetched breakdown to the file's results for that item and those states, as the Python does, and refuse it, saying so, where they differ.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions