Skip to content

A breakdown of another item or another step passes check and is drawn under the wrong item #5

Open

Description

@mklarmann

An item's breakdowns maps a step (or total) to a file name. check and page check that the breakdown adds up and that its totals are some item's results, but not that it is this item's breakdown of this step. Made-up case: rice names wheat's breakdown of fix-1 as its own for total: check exits 0 and the page draws wheat's parts under rice.

Proposed: breakdown.against takes the naming item and key, and refuses a breakdown whose item, from and to are not that item and that step's states.

Found by sentier-bafu's agent review of pull request #2 (head 5c19866), confirmed again on 0e1f5be. Being fixed on the same branch, first-version.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions