Skip to content

Review a step where it is chosen: its claim beside its effect, what it moved first - #21

Merged
mklarmann merged 6 commits into
dashboard-pagefrom
page-review
Nov 17, 2026
Merged

mklarmann merged 6 commits into
dashboard-pagefrom
page-review

Conversation

@mklarmann

Copy link
Copy Markdown
Collaborator

On top of #20 (dashboard-page, 7274efd), after Manuel's third look at the page in sentier-bafu's frame, side by side with the trial dashboard. #20 already makes it a matrix page. This adds what a reviewer still had to look for elsewhere.

What changes

  • The claim beside the effect. Under the chips is one line for the chosen step: the states it goes between, what it is, its claim with who made it, and what the claim found, from the file's own verdict counts. It reads "All 11 124 moves as claimed" in green, or "691 not claimed" in the signal colour, followed by the step's tolerance and noise. Before, the claim was only in the folded steps table.
  • What a step moved comes first. The matrix's columns come in the order of how much the chosen comparison moved in each indicator, the file's order among equals. An indicator in which nothing moved goes last, quietened, and keeps its column. On sentier-bafu's real chain, step 1 (the countries' factors) now opens with water use and land use. Before, they were off-screen at the right.
  • The address keeps the view. #step=<id>&item=<id>, each optional: a link opens the page on that step with that item open. Closing the item keeps the step, and an unknown step falls back to the whole way.
  • Keyboard: the arrow keys move between the chips.
  • Controls: the filters keep one line; the count, the matrix line and the legend take the row under them.
  • SPEC §10 and §10.5 say all of it.

How to check

  • node --test tests/js/page.test.js (54, from 50) and python3 -m unittest discover -s tests -t ..
  • Four new tests: the step line says the claim and what it found, and the address keeps the step; the columns follow what moved, quiet cells included; an address with a step and an item opens both; the arrow keys. Seven reverts of the new code, applied on a copy, each fail a test.
  • Looked at in a browser in sentier-bafu's frame on the real chain from BAFU's published results: 11,947 datasets × 25 impact categories, all in the matrix. Widths checked: 1500 and 1100 px, and a 375 px phone. The page's own example page was checked too. No console error.

Not checked

  • Dark mode: sentier-bafu's site has none to check against.
  • A screen reader. The chips are buttons with aria-pressed, and the step line is aria-live.

A person reviews and merges; the author does not merge it.

🤖 Generated with Claude Code

mklarmann and others added 5 commits November 17, 2026 02:34
…t moved first

Built on 7274efd (the chips, the grid first, the rest below), after Manuel's
third look in sentier-bafu's frame. What a reviewer still had to hunt for:

- What a step claimed. The claim sat in the folded steps table. Under the chips
  is now one line for the chosen step: the states it goes between, what it is,
  its claim with who made it, what the claim found ("All 11 124 moves as
  claimed", or "691 not claimed" in the signal colour), its tolerance and noise.
- What a step moved. The columns came in the file's order, so the countries'
  factors (water use and land use) sat off-screen at the far right. The matrix
  now puts first the indicators in which the chosen comparison moved most; one
  in which nothing moved comes last, quietened, and keeps its column.
- Where a reviewer is. The address keeps the chosen step with the open item
  (`#step=<id>&item=<id>`), so a link opens exactly that view; closing an item
  keeps the step, and an unknown step falls back to the whole way.
- The arrow keys move between the chips.
- The filters keep one line; the count, the matrix line and the legend take the
  row under them.

Tests: node 54 (from 50). Seven reverts, applied on a copy, each fail a test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ress

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ial dashboard has them

The distributions were a table of small bars, folded away at the foot of the page. They
are now always in view under the matrix, one card per indicator, in the order of the
matrix's columns (what the chosen comparison moved most first, the unmoved ones quiet).
Each card is a histogram of the file's own counts: across zero, down from far to near,
the band around 1, up from near to far, then the values with no ratio; on the scale of
its own tallest bar, every count in a bar's title.

Under it, how many moved, and the median, 10th and 90th percentile of after ÷ before,
in as many digits as keep apart the ones that differ. Those come only from every item
(the matrix, or a file that lists all): the listed ones are the furthest apart, and a
median of them would say more than the whole holds, so the card gives none and the
section says why.

A card's title sorts the matrix by its indicator; a heading of the matrix marks its card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each card on its own tallest bar is the default, as the trial dashboard draws them, so a
few values that moved are seen beside many that agree; one scale (the share of all values)
is a choice beside the legend, so that a bar of one height means as many in each card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…honest percentiles

From the review of 752043b and 38d6767:

- The line of a step names every verdict on a move with its count, "as claimed" first
  ("11 124 values moved as claimed"); "Nothing moved, as claimed" only where all are zero.
  Weight, not green or red: a verdict is not an approval (ADR 0010, A20).
- A column or card whose only change is a missing value is not quietened as if nothing
  moved: missing counts with what moved, and its title says so.
- The percentiles say over how many ratios they are taken and how many values have none;
  each is widened only as far as its neighbour needs, and two that six digits cannot part
  read "just under the median" / "just over the median".
- Each card says what its full height is ("tallest bar: 7", or on one scale the share).
- The axis words fit at 375 px (↓ ÷10, ×10 ↑).
- SPEC: the distributions are open under the matrix; 10.3 says per card is the default and
  why, one scale a switch, and that the percentiles are the one number the page works out,
  from every item only; 10.5 says choosing a comparison sorts furthest-first again; A21.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ring pair apart

Each percentile was widened on its own, so one line could mix precisions:
1.00004, 1.00005, 1.00006 read "1.0000, 1.00005, 1.00006", a rounded 10th
percentile standing as exactly 1 beside a six-digit median. Now the three
share one precision, the smallest (3 to 6) at which every two that differ
read differently. Where six digits cannot part a percentile from the
median, it is said in words and the numbers left take the digits they need
("just under the median, 1.00, 5.95"). Found in review by the
sentier-diagnostics session.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mklarmann
mklarmann merged commit a217b5a into dashboard-page Nov 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant