Repository navigation
Review a step where it is chosen: its claim beside its effect, what it moved first - #21
Merged
Merged
Conversation
…t moved first Built on 7274efd (the chips, the grid first, the rest below), after Manuel's third look in sentier-bafu's frame. What a reviewer still had to hunt for: - What a step claimed. The claim sat in the folded steps table. Under the chips is now one line for the chosen step: the states it goes between, what it is, its claim with who made it, what the claim found ("All 11 124 moves as claimed", or "691 not claimed" in the signal colour), its tolerance and noise. - What a step moved. The columns came in the file's order, so the countries' factors (water use and land use) sat off-screen at the far right. The matrix now puts first the indicators in which the chosen comparison moved most; one in which nothing moved comes last, quietened, and keeps its column. - Where a reviewer is. The address keeps the chosen step with the open item (`#step=<id>&item=<id>`), so a link opens exactly that view; closing an item keeps the step, and an unknown step falls back to the whole way. - The arrow keys move between the chips. - The filters keep one line; the count, the matrix line and the legend take the row under them. Tests: node 54 (from 50). Seven reverts, applied on a copy, each fail a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ress Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ial dashboard has them The distributions were a table of small bars, folded away at the foot of the page. They are now always in view under the matrix, one card per indicator, in the order of the matrix's columns (what the chosen comparison moved most first, the unmoved ones quiet). Each card is a histogram of the file's own counts: across zero, down from far to near, the band around 1, up from near to far, then the values with no ratio; on the scale of its own tallest bar, every count in a bar's title. Under it, how many moved, and the median, 10th and 90th percentile of after ÷ before, in as many digits as keep apart the ones that differ. Those come only from every item (the matrix, or a file that lists all): the listed ones are the furthest apart, and a median of them would say more than the whole holds, so the card gives none and the section says why. A card's title sorts the matrix by its indicator; a heading of the matrix marks its card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each card on its own tallest bar is the default, as the trial dashboard draws them, so a few values that moved are seen beside many that agree; one scale (the share of all values) is a choice beside the legend, so that a bar of one height means as many in each card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…honest percentiles From the review of 752043b and 38d6767: - The line of a step names every verdict on a move with its count, "as claimed" first ("11 124 values moved as claimed"); "Nothing moved, as claimed" only where all are zero. Weight, not green or red: a verdict is not an approval (ADR 0010, A20). - A column or card whose only change is a missing value is not quietened as if nothing moved: missing counts with what moved, and its title says so. - The percentiles say over how many ratios they are taken and how many values have none; each is widened only as far as its neighbour needs, and two that six digits cannot part read "just under the median" / "just over the median". - Each card says what its full height is ("tallest bar: 7", or on one scale the share). - The axis words fit at 375 px (↓ ÷10, ×10 ↑). - SPEC: the distributions are open under the matrix; 10.3 says per card is the default and why, one scale a switch, and that the percentiles are the one number the page works out, from every item only; 10.5 says choosing a comparison sorts furthest-first again; A21. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ring pair apart
Each percentile was widened on its own, so one line could mix precisions:
1.00004, 1.00005, 1.00006 read "1.0000, 1.00005, 1.00006", a rounded 10th
percentile standing as exactly 1 beside a six-digit median. Now the three
share one precision, the smallest (3 to 6) at which every two that differ
read differently. Where six digits cannot part a percentile from the
median, it is said in words and the numbers left take the digits they need
("just under the median, 1.00, 5.95"). Found in review by the
sentier-diagnostics session.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #20 (
dashboard-page, 7274efd), after Manuel's third look at the page in sentier-bafu's frame, side by side with the trial dashboard. #20 already makes it a matrix page. This adds what a reviewer still had to look for elsewhere.What changes
#step=<id>&item=<id>, each optional: a link opens the page on that step with that item open. Closing the item keeps the step, and an unknown step falls back to the whole way.How to check
node --test tests/js/page.test.js(54, from 50) andpython3 -m unittest discover -s tests -t ..Not checked
aria-pressed, and the step line isaria-live.A person reviews and merges; the author does not merge it.
🤖 Generated with Claude Code