Skip to content

improve container credentials retrieval matching container repository names - #278

Closed
munishchouhan wants to merge 52 commits into
masterfrom
224-improve-container-credentials-retrieval-matching-container-repository-names
Closed

munishchouhan wants to merge 52 commits into
masterfrom
224-improve-container-credentials-retrieval-matching-container-repository-names

Conversation

@munishchouhan

@munishchouhan munishchouhan commented Aug 8, 2023 •

Copy link
Copy Markdown
Member
  1. wave should support repository credential validation
  2. Wave should choose the best matching credentials from the tower for a give registry/repository name

@munishchouhan
munishchouhan marked this pull request as draft August 8, 2023 19:39
@munishchouhan munishchouhan self-assigned this Aug 9, 2023
Comment thread src/main/groovy/io/seqera/wave/auth/RegistryAuthServiceImpl.groovy Outdated
@munishchouhan
munishchouhan marked this pull request as ready for review August 16, 2023 17:03
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
munishchouhan and others added 8 commits November 29, 2023 13:39
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
pditommaso force-pushed the 224-improve-container-credentials-retrieval-matching-container-repository-names branch from 1a7df00 to 4fbf3bb Compare December 21, 2023 16:04
@gitguardian

This comment was marked as outdated.

munishchouhan and others added 7 commits August 30, 2024 11:28
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
…er-credentials-retrieval-matching-container-repository-names

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s-retrieval-matching-container-repository-names' into 224-improve-container-credentials-retrieval-matching-container-repository-names

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pditommaso

Copy link
Copy Markdown
Collaborator

Closing in favour of #1165, which implements the repository-based credentials matching described in #224.

@pditommaso pditommaso closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve container credentials retrieval matching container repository names

3 participants