feat: added style CI check && replaced serde_json with serde_test - #434
Merged
Conversation
alejandro-vaz
marked this pull request as ready for review
August 22, 2026 14:00
alejandro-vaz
changed the title
serde_json with serde_testserde_json with serde_test
Member
|
Can you remove the merge commits so we have linear history please? |
Contributor
Author
|
oh yeah |
Contributor
Author
|
done |
emilio
approved these changes
Aug 22, 2026
Member
|
Personally would've split this PR in two but looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde_jsonwithserde_test(removes dependency bloat) replaceserde_jsondev-dependency forserde_test#428removes four dependencies from
serde_json