Tests: add Python bindings and system tests for conversion tools - #1673
Open
ikerexxe wants to merge 9 commits into
Open
Tests: add Python bindings and system tests for conversion tools#1673ikerexxe wants to merge 9 commits into
ikerexxe wants to merge 9 commits into
Conversation
ikerexxe
force-pushed
the
test-conversion-bindings
branch
from
July 14, 2026 07:30
8f19008 to
84cd83c
Compare
ikerexxe
force-pushed
the
test-conversion-bindings
branch
3 times, most recently
from
July 15, 2026 12:16
3e51e2e to
98c54a9
Compare
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This is a partial transformation to Python of the test located in `tests/convtools/01/run`, which checks that `pwconv` is able to convert passwd format to shadow format. The test is more complex and checks different transformations (i.e. pwconv, pwunconv), so it will be transformed to several tests. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This is a partial transformation to Python of the test located in `tests/convtools/01/run`, which checks that `pwunconv` is able to convert shadow format back to passwd format. The test is more complex and checks different transformations (i.e. pwconv, pwunconv), so it will be transformed to several tests. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This is a partial transformation to Python of the test located in `tests/convtools/01/run`, which checks that `grpconv` is able to convert group format to shadow format. The test is more complex and checks different transformations (i.e. pwconv, pwunconv), so it will be transformed to several tests. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
…onv` Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This is a partial transformation to Python of the test located in `tests/convtools/01/run`, which checks that `grpunconv` is able to convert shadow format back to group format. The test is more complex and checks different transformations (i.e. pwconv, pwunconv), so it will be transformed to several tests. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
test-conversion-bindings
branch
from
August 27, 2026 13:30
98c54a9 to
79a3f83
Compare
ikerexxe
marked this pull request as ready for review
August 27, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 4 new methods to
shadowrole to wrap the conversion tools:pwconv,pwunconv,grpconvandgrpunconv.Add 4 test cases to validate the wrappers with comprehensive user/group entry validation, file permissions checking and cross-platform compatibility. The tests mirror the behavior from
convtools/01/runwhere the conversion tools convert system authentication files between old and shadow formats.