Repository navigation
Netinstaller - #1
Conversation
The netinstaller branch ships a live environment with nothing but the boot system, network drivers and a console menu. All desktop, application and role packages are downloaded from the Arch mirrors by pacstrap when the install runs — the menu is select -> download -> install. - installer/menu: interactive text menu (stdlib + PyYAML only) driving the same run_installation() orchestrator as the GTK GUI and CLI; network pre-flight with retry guidance (nmtui for wi-fi), plan preview with package count, typed device-name confirmation before disk wipe, --dry-run mode - live env slimmed to 19 packages (dropped gtk3, python-gobject, git, openssh, vim, tmux, alsa-utils — no GUI/tooling on the ISO) - tty1 autologin launches the menu via root/.bash_profile; /usr/local/bin/modular-menu wrapper for manual starts - removed inapplicable services (graphical installer, sshd, alsa-unmuter, livecd-talk) - README-netinstall.md documents the edition and its differences from main; README carries a branch banner - 9 new regression tests (111 total)
Reviewer's GuideThis PR introduces a minimal online-installer ISO edition with a reusable text menu front end, network and disk safety checks, configuration/plan preview, and shared installation orchestration; it packages the menu as the tty1 live-environment entry point, removes graphical-live services, adds regression coverage and documentation, and enables CI for the branch. Sequence diagram for the netinstall menu and installation flowsequenceDiagram
actor User
participant TTY1
participant TextMenu
participant Mirror
participant Resolver
participant Plan
participant Installer
User->>TTY1: Login on tty1
TTY1->>TextMenu: main()
TextMenu->>Mirror: check_network()
Mirror-->>TextMenu: Reachability result
User->>TextMenu: Select desktop, hardware, roles, applications, system, identity, disk
TextMenu->>Resolver: resolve()
Resolver-->>TextMenu: Resolved packages
TextMenu->>Plan: build_plan()
Plan-->>TextMenu: Package count
TextMenu->>TextMenu: ModularConfiguration.save()
User->>TextMenu: Confirm installation
TextMenu->>Installer: run_installation()
Installer-->>User: Installation result
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
📝 WalkthroughWalkthroughThe change adds a netinstall text menu, integrates it into the live ISO, reduces ISO packages and automatic services, adds menu tests, documents the netinstaller branch, and enables CI for that branch. ChangesNetinstaller edition
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant RootShell
participant TextMenu
participant ProfileRegistry
participant InstallerEngine
RootShell->>TextMenu: Launch the netinstall menu
TextMenu->>TextMenu: Check network and collect selections
TextMenu->>ProfileRegistry: Resolve selected profiles
TextMenu->>InstallerEngine: Build configuration and package plan
TextMenu->>InstallerEngine: Run installation
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="installer/menu/text_menu.py" line_range="280-285" />
<code_context>
+ entries = [(p.id, p.name) for p in profiles]
+ return self.ask_multiselect("select roles", entries)
+
+ def step_applications(self) -> list[str]:
+ self._out("\n[5/8] applications (downloaded at install time)")
+ profiles = self.registry.by_category("applications")
+ entries = [(p.id, p.name) for p in profiles]
+ self._out(f" {len(entries)} applications available")
+ return self.ask_multiselect("select applications", entries)
+
+ def step_system(self) -> dict[str, str]:
</code_context>
<issue_to_address>
**issue (broader_impact):** The menu exposes every application profile, including AUR profiles, but the installation path sends only `plan.all_packages()` to pacstrap. `InstallationPlan.all_packages()` contains only the base and official package lists, so selected AUR applications are omitted from the actual installation while the menu presents them as selectable applications.
**Triggers:** When the user selects an application profile whose source is AUR, such as `brave`, `ghidra`, `heroic`, `onlyoffice`, or `vivaldi`.
**Suggested fix:** Either hide unsupported non-official profiles in the netinstall menu or add the corresponding AUR installation workflow and include its packages in the installation steps.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and the new menu adds a live installation path that can invoke the shared orchestrator to partition and wipe a user-selected disk, so a targeting or confirmation defect could irreversibly destroy data. The menu also collects and passes user and root passwords into the installation flow; reverting removes this path, but any disk contents already erased would not be recoverable.
Blocking findings: installer/menu/text_menu.py:285
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| def step_applications(self) -> list[str]: | ||
| self._out("\n[5/8] applications (downloaded at install time)") | ||
| profiles = self.registry.by_category("applications") | ||
| entries = [(p.id, p.name) for p in profiles] | ||
| self._out(f" {len(entries)} applications available") | ||
| return self.ask_multiselect("select applications", entries) |
There was a problem hiding this comment.
issue (broader_impact): The menu exposes every application profile, including AUR profiles, but the installation path sends only plan.all_packages() to pacstrap. InstallationPlan.all_packages() contains only the base and official package lists, so selected AUR applications are omitted from the actual installation while the menu presents them as selectable applications.
Triggers: When the user selects an application profile whose source is AUR, such as brave, ghidra, heroic, onlyoffice, or vivaldi.
Suggested fix: Either hide unsupported non-official profiles in the netinstall menu or add the corresponding AUR installation workflow and include its packages in the installation steps.
What does this PR do?
Which layer does it touch?
profiles/— declarative YAML onlyengine/— resolution/validation logicinstaller/— execution path (partitioning, pacstrap, chroot)cli/orcmd/modular/— command line surfaceiso/— live environmentChecklist
python -m pytest tests/passes locallypython scripts/validate-profiles.pypasses (if profiles changed)tests/installation/)gofmt -l .is clean (if Go changed)Summary by Sourcery
Introduce a minimal network-based installer ISO with an interactive console workflow that shares the existing installation engine and downloads selected packages during installation.
New Features:
Enhancements:
Build:
CI:
Documentation:
Tests:
Summary by CodeRabbit
modular-menucommand for launching the installer manually.netinstallerbranch.