Centre the transparency checkerboard vertically - #328
Merged
Conversation
The checkerboard is an ImageShader tiling from the Canvas origin, so it started flush with the track's top edge and let the bottom edge fall wherever the height ran out. At a 16dp track over 6dp cells that is a full 6dp row against a 4dp stub, on a pattern only three rows tall, and the mismatch reads as a mistake rather than a texture. The fill is now shifted up by half the overshoot, so the remainder is split evenly and both edges show the same sliver: measured on the recorded golden, the alpha track's rows go from 16/16/10 pixels to 13/15/12. The fill is grown by the overshoot so it still covers the track, and the existing clip trims it. Only the vertical axis is anchored. Horizontally a track spans dozens of cells, so a partial cell at one end is invisible, and leaving the horizontal phase alone keeps the pattern continuous across the gap the thumb cuts in the track — anchoring each segment separately would make it jump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkerboard is an ImageShader tiling from the Canvas origin, so it started flush with the track's top edge and let the bottom edge fall wherever the height ran out. At a 16dp track over 6dp cells that is a full 6dp row against a 4dp stub, on a pattern only three rows tall, and the mismatch reads as a mistake rather than a texture.
The fill is now shifted up by half the overshoot, so the remainder is split evenly and both edges show the same sliver: measured on the recorded golden, the alpha track's rows go from 16/16/10 pixels to 13/15/12. The fill is grown by the overshoot so it still covers the track, and the existing clip trims it.
Only the vertical axis is anchored. Horizontally a track spans dozens of cells, so a partial cell at one end is invisible, and leaving the horizontal phase alone keeps the pattern continuous across the gap the thumb cuts in the track — anchoring each segment separately would make it jump.