Repository navigation
Credit Hero under the film again - #16
Merged
Merged
Conversation
The film is cut from Hero, which is CC BY 4.0. Its end card credits it, but nobody who skips the film sees that, so the caption goes back under it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The film on the home page is cut from Hero by the Blender Foundation, which is CC BY 4.0. a506b09 took the caption out because the film's end card credits Hero, but anyone who doesn't play the film never sees that card.
This puts the old line back under the film: "Footage from Hero by the Blender Foundation, CC BY 4.0, edited." It links to the Hero project page and the licence, and uses the same caption style as the comparison above it.
tests/test_site.pygetstest_the_film_credits_hero_under_it, which fails if the film's figure loses that caption. All 42 site tests pass.