Merge duplicate token analyses on PT9 import (#313) - #392
Open
alex-rawlings-yyc wants to merge 1 commit into
Open
alex-rawlings-yyc wants to merge 1 commit into
alex-rawlings-yyc wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #313.
Summary
analysesAreIdenticalrule, so surface forms differing only in case also merge. It covers both analyses from interlinear clusters and the unlinked ones from the word-analysis inventories.merge.identicalPayloadsMergedcount. The import modal doesn't show it.buildBareWordAnalyseskeeps its own duplicate check, soskippedExistingIdenticalstill counts what it did. The merge runs after every other conversion step, so analyses made identical by #324's blank-morpheme stripping will merge too.Out of scope: a merged analysis shows the surface text of whichever token came first, e.g. a capitalized sentence-initial form; deriving the displayed form from its links belongs to #186. PT9 import still writes one phrase payload per occurrence; that has its own issue.
Test plan
test-data/pt9-projects/PIA): the fourplovstokens in PHP 1:6-7 end up on three analyses, with the two "catorce / plov s" occurrences sharing oneplovssuggestion dropdown has no duplicate rowsThis change is