Skip to content

feat(editor): metadata panel, subject editing, and variable catalogue - #95

Open
patoperpetua wants to merge 1 commit into
mainfrom
feat/44-editor-metadata-ui
Open

feat(editor): metadata panel, subject editing, and variable catalogue#95
patoperpetua wants to merge 1 commit into
mainfrom
feat/44-editor-metadata-ui

Conversation

@patoperpetua

Copy link
Copy Markdown
Contributor

Summary

  • Adds MetadataPanel (key, name, description, subject; read-only schemaVersion) and VariableCatalogue (copy/insert, declare add/remove) to @singleton-sd/post-kit-editor.
  • Wires both into EmailTemplateEditor working TemplateSourceFiles state beside the existing EmailBuilder canvas; subject supports cursor insert + live preview-data hint.
  • Constrains template key input to publisher-safe charset ([a-zA-Z0-9._-], not ./..); clipboard copy degrades without throwing.

Closes #44

Test plan

  • pnpm --filter @singleton-sd/post-kit-editor test (45 passing)
  • pnpm --filter @singleton-sd/post-kit-editor build
  • Confirm canvas from EmailBuilder.js canvas and lossless template source load/serialize #40 still renders editable document in a consumer host
  • Smoke: edit name/key/subject; reject key with / or spaces; insert {{name}} into focused subject; copy placeholder

Made with Cursor

…ogue

Wire controlled metadata fields and a variable catalogue into EmailTemplateEditor
working TemplateSourceFiles state so admins can edit key/name/description/subject
and copy or insert placeholders without memorising variable names.

Closes #44

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 781358af-51f9-4c40-8b9a-6f7a5576201f

📥 Commits

Reviewing files that changed from the base of the PR and between e40f3e1 and ca8a002.

📒 Files selected for processing (15)
  • packages/post-kit-editor/src/email-template-editor.tsx
  • packages/post-kit-editor/src/index.spec.tsx
  • packages/post-kit-editor/src/insertion-target.tsx
  • packages/post-kit-editor/src/metadata/MetadataPanel.spec.tsx
  • packages/post-kit-editor/src/metadata/MetadataPanel.tsx
  • packages/post-kit-editor/src/metadata/insert-at-cursor.ts
  • packages/post-kit-editor/src/metadata/metadata-helpers.spec.ts
  • packages/post-kit-editor/src/metadata/subject-preview.ts
  • packages/post-kit-editor/src/metadata/template-key.ts
  • packages/post-kit-editor/src/types.ts
  • packages/post-kit-editor/src/variables/VariableCatalogue.tsx
  • packages/post-kit-editor/src/variables/clipboard.ts
  • packages/post-kit-editor/src/variables/resolve-catalogue.ts
  • packages/post-kit-editor/src/variables/variable-catalogue.spec.tsx
  • packages/post-kit-editor/src/working-files.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patoperpetua

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 39 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata, subject editing, and variable catalogue UI

1 participant