Fix stub instance call order in sandboxes - #2761
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix #2760 so methods created by
createStubInstanceparticipate in call-order comparisons with spies and stubs from the same sandbox.Background (Problem in detail)
Sandbox spies and stubs use a private call-ID context, but
createStubInstancecreated its method stubs through the default global context. As a result,calledBeforeandcalledAftercompared unrelated counters and could report the wrong order.Solution
Thread the sandbox call-ID context into stub-instance creation, while preserving the standalone helper's existing default behavior. The root Sinon API now delegates to its root sandbox implementation so collection and call ordering follow the same path.
How to verify - mandatory
npm installnpx mocha test/src/create-sinon-api-test.js test/src/sandbox-test.js --timeout 10000npm run lintChecklist for author
npm run lintpasses