Skip to content

fix(monitoring): bound route key cardinality for unknown request methods - #63

Merged
CypherPotato merged 1 commit into
mainfrom
fix/monitoring-route-key-cardinality
Nov 18, 2026
Merged

CypherPotato merged 1 commit into
mainfrom
fix/monitoring-route-key-cardinality

Conversation

@CypherPotato

Copy link
Copy Markdown
Member

Problem

The dashboard route key is built from the raw request method token. On RouteMethod.Any routes every method token is accepted, so each distinct token creates a new route key. Once the 200 tracked route slots are filled, routes not seen yet are only reported under (other routes).

Fix

TrackHttpRequestClose now keeps the method in the key only for the methods known by the router (GET, POST, PUT, PATCH, DELETE, HEAD, OPTIONS, QUERY, ordinal match). Any other method is recorded as OTHER <path>. Keys for known methods are unchanged.

Test

UseMonitoring_DoesNotTrackClientMethodTokensAsRoutes sends 230 distinct methods to a MapAny route, then GET /late, and checks that /monitoring/data lists GET /late and OTHER /any and no client method tokens. It fails without the fix and passes with it.

Note: Sisk.Monitoring.Tests is not part of the Run tests workflow (it only runs tests/Sisk.Core); it was run locally.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T11:42:16.634334Z 6f91824 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@CypherPotato
CypherPotato merged commit 5703bcb into main Nov 18, 2026
5 checks passed
@CypherPotato
CypherPotato deleted the fix/monitoring-route-key-cardinality branch November 18, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant