Skip to content

refactor(infra): remove iris legacy manifests - #3733

Merged
keulma merged 2 commits into
mainfrom
t2895-remove-iris-legacy
Sep 4, 2026
Merged

refactor(infra): remove iris legacy manifests#3733
keulma merged 2 commits into
mainfrom
t2895-remove-iris-legacy

Conversation

@tasoo-oos

@tasoo-oos tasoo-oos commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

  • 사용이 종료된 infra/k8s/iris-legacy/ 매니페스트를 삭제합니다.
  • 운영 iris-legacy 네임스페이스가 Argo CD 관리 대상이 아님을 문서에 명시합니다.
  • 병합 후 운영 클러스터의 iris-legacy 네임스페이스를 수동 삭제하고 ExternalSecret 동기화 중단을 확인합니다.

Additional context

  • 저장소 파일 삭제만으로 운영 리소스는 삭제되지 않습니다. 이는 kubectl을 통해 수동으로 진행할 예정입니다.

Before submitting the PR, please make sure you do the following

Closes TAS-2895

Summary by CodeRabbit

  • Chores
    • Removed infrastructure manifests and credentials for the iris-legacy Kubernetes environment.
    • Updated decommissioning guidance to require manual removal of the live production namespace before cleanup.
    • Clarified that broker credentials are retired after the live namespace is removed.
  • Documentation
    • Removed documentation describing the legacy Iris service and its potential failover use.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 0b2a6cb8-ac50-43ca-8be0-a62aa06dd687

📥 Commits

Reviewing files that changed from the base of the PR and between 866cd05 and 971d558.

📒 Files selected for processing (1)
  • infra/aws/decommission-stage/README.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 76f5819a-b27a-43e0-89da-1fa6d740f996

📥 Commits

Reviewing files that changed from the base of the PR and between 4ae1f7e and 866cd05.

📒 Files selected for processing (7)
  • infra/aws/decommission-stage/README.md
  • infra/aws/decommission-stage/message-queue.tf
  • infra/k8s/iris-legacy/README.md
  • infra/k8s/iris-legacy/aws-credentials.yaml
  • infra/k8s/iris-legacy/deployment.yaml
  • infra/k8s/iris-legacy/external-secret.yaml
  • infra/k8s/iris-legacy/namespace.yaml
💤 Files with no reviewable changes (5)
  • infra/k8s/iris-legacy/aws-credentials.yaml
  • infra/k8s/iris-legacy/external-secret.yaml
  • infra/k8s/iris-legacy/deployment.yaml
  • infra/k8s/iris-legacy/namespace.yaml
  • infra/k8s/iris-legacy/README.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change removes the iris-legacy namespace manifest and updates AWS decommission documentation and comments to require manual namespace removal before retiring the broker credential.

Changes

iris-legacy decommission

Layer / File(s) Summary
Remove namespace and update decommission procedure
infra/k8s/iris-legacy/namespace.yaml, infra/aws/decommission-stage/README.md, infra/aws/decommission-stage/message-queue.tf
The iris-legacy namespace manifest is deleted. The decommission procedure and Secrets Manager comment now reference manual removal of the live namespace before broker credential retirement.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 866cd

This PR removes obsolete iris-legacy manifests and updates the related documentation; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: woo943

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The pull request removes iris-legacy infrastructure manifests and updates decommissioning documentation. Linked issue #123 requires implementation of a frontend ProgressCard component, which this pull… Link the pull request to the issue for iris-legacy decommissioning, or update the changes to implement the ProgressCard requirements from issue #123.
Out of Scope Changes check ⚠️ Warning The infrastructure deletions and documentation updates are unrelated to the requirements in linked issue #123, which concerns a frontend ProgressCard component. Remove the unrelated infrastructure changes from this issue, or correct the linked issue to the iris-legacy decommissioning objective. Implement the ProgressCard separately if issue #123 remains linked.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: removal of the Iris legacy infrastructure manifests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The pull request removes iris-legacy infrastructure manifests and updates decommissioning documentation. Linked issue #123 requires implementation of a frontend ProgressCard component, which this pull request does not address.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t2895-remove-iris-legacy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tasoo-oos tasoo-oos self-assigned this Sep 2, 2026
@tasoo-oos
tasoo-oos requested review from goathoon, keulma and sunghyun1000 and removed request for goathoon September 2, 2026 17:46
@tasoo-oos
tasoo-oos marked this pull request as ready for review September 2, 2026 17:47

@keulma keulma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iris-legacy의 replicas가 0으로 설정되어있어 stage, prod context에서도 pod가 실제로 동작하고 있지는 않습니다. 병합 이후 서비스 중단 없이 kubectl 수동진행해도 좋을 듯 합니다.

LGTM! 수고하셨습니다.

@keulma
keulma added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 6e24ffb Sep 4, 2026
19 checks passed
@keulma
keulma deleted the t2895-remove-iris-legacy branch September 4, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants