refactor(infra): remove iris legacy manifests - #3733
Conversation
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change removes the Changesiris-legacy decommission
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR removes obsolete iris-legacy manifests and updates the related documentation; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation The pull request removes iris-legacy infrastructure manifests and updates decommissioning documentation. Linked issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
keulma
left a comment
There was a problem hiding this comment.
iris-legacy의 replicas가 0으로 설정되어있어 stage, prod context에서도 pod가 실제로 동작하고 있지는 않습니다. 병합 이후 서비스 중단 없이 kubectl 수동진행해도 좋을 듯 합니다.
LGTM! 수고하셨습니다.
Description
infra/k8s/iris-legacy/매니페스트를 삭제합니다.iris-legacy네임스페이스가 Argo CD 관리 대상이 아님을 문서에 명시합니다.iris-legacy네임스페이스를 수동 삭제하고 ExternalSecret 동기화 중단을 확인합니다.Additional context
kubectl을 통해 수동으로 진행할 예정입니다.Before submitting the PR, please make sure you do the following
fixes #123).Closes TAS-2895
Summary by CodeRabbit
iris-legacyKubernetes environment.