Skip to content

SK-3002 stop publishing build-internal jars to Maven Central #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Devesh-Skyflow wants to merge 1 commit into from
Closed

SK-3002 stop publishing build-internal jars to Maven Central #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions flowvault/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,17 @@
</executions>
</plugin>
<plugin>
<!-- Comparison-only jar (classifier "with-common") merging com.skyflow:common,
mirroring skyvault. The published artifact is untouched: shadedArtifactAttached
keeps the main jar as it was. This exists so japicmp compares the whole surface
a consumer actually gets, since classes a customer imports (Credentials,
SkyflowException, BearerToken) live in common and would otherwise read as
missing - japicmp only sees what is physically inside the jars it is given. -->
<!-- Comparison-only jar merging com.skyflow:common, mirroring skyvault. This
exists so japicmp compares the whole surface a consumer actually gets, since
classes a customer imports (Credentials, SkyflowException, BearerToken) live
in common and would otherwise read as missing - japicmp only sees what is
physically inside the jars it is given.
Written with outputFile, NOT shadedArtifactAttached: attaching it made it a
secondary artifact, and every attached artifact is deployed, so this
build-internal jar was being published to Maven Central as a permanent
-with-common classifier. outputFile writes the jar and neither replaces the
main artifact nor attaches it. The path is unchanged, so the japicmp
newVersion path below still resolves. -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.6.0</version>
Expand All @@ -95,8 +100,7 @@
<goal>shade</goal>
</goals>
<configuration>
<shadedArtifactAttached>true</shadedArtifactAttached>
<shadedClassifierName>with-common</shadedClassifierName>
<outputFile>${project.build.directory}/${project.build.finalName}-with-common.jar</outputFile>
<artifactSet>
<includes>
<include>com.skyflow:common</include>
Expand Down
15 changes: 6 additions & 9 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,15 +232,12 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.3.0</version>
<executions>
<execution>
<goals>
<goal>test-jar</goal>
</goals>
</execution>
</executions>
<configuration>
</configuration>
<!-- No test-jar execution. The 'test-jar' goal ATTACHES the jar as a secondary
artifact, and every attached artifact gets deployed - so it was being
published to Maven Central as a permanent -tests.jar classifier alongside
the SDK. Nothing in this repo depends on a test-jar (no <type>test-jar</type>
dependency anywhere), and the release build's own tests run in-module, so
generating it served no purpose. -->
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
17 changes: 9 additions & 8 deletions skyvault/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,18 @@
</executions>
</plugin>
<plugin>
<!-- Produces an additional, comparison-only jar (classifier "with-common")
that merges in com.skyflow:common, same pattern flowvault already uses.
The real published skyflow-java-2.1.1.jar is untouched (shadedArtifactAttached
keeps the main artifact slim) - this attached jar exists only so japicmp can
compare an apples-to-apples "everything a v2 consumer actually gets" surface
<!-- Produces an additional, comparison-only jar that merges in
com.skyflow:common, same pattern flowvault already uses. It exists only so
japicmp can compare an apples-to-apples "everything a v2 consumer gets" surface
against the old 2.1.0 baseline, which was a single self-contained jar
(predating the common/v2 split). Without this, classes that moved into
common (Credentials, ErrorCode, BearerToken, Token, etc.) would show up as
false-positive "removed" classes, since japicmp only compares what's
physically inside the two jars it's given. -->
physically inside the two jars it's given.
Written with outputFile rather than shadedArtifactAttached: attaching it made
it a secondary artifact, and attached artifacts are deployed, so a jar
documented here as comparison-only was being published. outputFile keeps it
on disk without attaching. Path unchanged, so japicmp still resolves it. -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.6.0</version>
Expand All @@ -81,8 +83,7 @@
<goal>shade</goal>
</goals>
<configuration>
<shadedArtifactAttached>true</shadedArtifactAttached>
<shadedClassifierName>with-common</shadedClassifierName>
<outputFile>${project.build.directory}/${project.build.finalName}-with-common.jar</outputFile>
<artifactSet>
<includes>
<include>com.skyflow:common</include>
Expand Down
Loading