fix CodeQL code scanning warning - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在 #112 中，忘记给 build-gcc 这个 job 设置 permissions 了，导致 CodeQL code scanning 还有一个 warning 没消除（需要开启/配置 CodeQL code scanning 才可以看到）：
本 PR 把设置在 build-msvc 上的 permission 挪至顶端，以便于应用到 build-msvc、build-gcc 两个 jobs（release job 已单独设置了 write 权限，会覆盖这个全局的权限）。