Repository navigation
feat: add the user_connections feature to the manifest schema - #98
Merged
WilliamBergamin merged 1 commit intoOct 23, 2026
Merged
WilliamBergamin merged 1 commit into
WilliamBergamin merged 1 commit into
Conversation
Adds features.user_connections (is_enabled, auth_hosts) to the v1 and v2 schemas so editors stop flagging manifests that opt into standardized app authentication. Constraints mirror Slack's own manifest validation: both fields required, no extra keys, and auth_hosts as bare hosts. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
approved these changes
Oct 22, 2026
zimeg
left a comment
zimeg
left a comment
Member
There was a problem hiding this comment.
🚢 @WilliamBergamin A good addition to have I think! LGTM!
WilliamBergamin
merged commit Oct 23, 2026
a6257c8
into
clack/manifest-code-channels-tests
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the
features.user_connectionsproperty (is_enabled,auth_hosts) to the v1 and v2 manifest schemas, so editors stop flagging manifests that opt into standardized app authentication.auth_hostsholds bare hosts (no scheme).mainonce test: cover in progress code_channels in the v1/v2 manifest fixtures #87 merges.Testing
manifest.jsonin VS Code with"$schema"pointing at this branch'sschemas/manifest.schema.2.0.0.json, addfeatures.user_connectionswithis_enabledandauth_hosts, and confirm it autocompletes with no warning.auth_hosts, or add a host likehttps://example.com, and confirm the editor flags it.Category
manifest.schema.jsonedit/schemaand/or its core componentsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.🤖 Generated with Claude Code