test(registries): pin the Teredo client-XOR branch with a public-server vector - #1263
Merged
Conversation
…er vector The Teredo vector added in #1235 had an all-zero server field, so IsUnspecified blocked it before the XOR'd client address was ever decoded; deleting the XOR branch left the test green. Use a public Teredo server (65.54.227.120) with a loopback client, and add the public-client counterpart to the allowed list. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
330cd04
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://157817f5.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://test-1235-teredo-vector.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 34675785340 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1235 (thanks @aroh3006).
Problem
The Teredo vector
2001:0:0:0:0:0:80ff:fffehas a0.0.0.0server field, whichIsUnspecifiedblocks before the XOR-obfuscated client (127.0.0.1) is decoded. Removing the client-XOR line inembeddedIPv4leftTestIsBlockedIPgreen.Fix
Use
2001:0:4136:e378::80ff:fffe(public server 65.54.227.120, loopback client) so only the client branch can produce the block, and add2001:0:4136:e378::f7f7:f7fe(client 8.8.8.1) to the allowed list to pin the branch from both sides.Testing
Verified the test now bites: replacing the XOR with the raw bytes fails
TestIsBlockedIP; restored,go test ./internal/registries/passes.🤖 Generated with Claude Code