Repository navigation
Revert BigQuery read-only rollups (regressed abler-web-prod) - #89
Merged
Merged
Conversation
This reverts commit 87e08c9. Live on dev it regressed abler-web-prod: read-only downloads infer column types from the rows, so a decimal after integer-looking values fails the Cube Store upload ("Can't parse int"), and empty partitions cannot build at all. Adding readOnly to dbParams also changed the datasource's hash, and Cube Store dropped about 1,500 of its 2,198 rollup tables. Back to staging until read-only takes column types from BigQuery's schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the read-only part of #88 (87e08c9). The crash fix from #88 stays: since the deploy there have been 0 worker restarts and no uncaught exceptions.
On dev, read-only regressed abler-web-prod:
Can't parse int), and empty partitions cannot build at all.readOnlychanged the datasource's hash, and Cube Store dropped about 1,500 of its 2,198 rollup tables.Reverting restores the old hash and the staging build path.
🤖 Generated with Claude Code