This repository was archived by the owner on Sep 30, 2026. It is now read-only.
Repository navigation
ci: test on node 20 and declare node >=20 engine - #655
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mfeltscher
force-pushed
the
fix/add-types-node
branch
from
September 30, 2026 08:05
a641394 to
cda3406
Compare
mfeltscher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original fix in this PR (explicit
@types/node, CI matrix → 22/24,RS256alg fix) already landed on main via #511: renovate automerged that PR while it was stacked on this branch.What remains:
engines.node: ">=20". jose 6 and openid-client 6 need Node 20+ anyway.Note: ava 8 declares
node ^22.20 || >=24.12, but runs fine on Node 20 (30/30 tests pass locally on 20.20.2). npm only prints an EBADENGINE warning.🤖 Generated with Claude Code