Repository navigation
fix(gh-wrapper): refuse GraphQL enablePullRequestAutoMerge - #446
Merged
Merged
Conversation
Turning on auto-merge through `gh api graphql` lets a PR merge later without the merge-lock or pre-merge review. The GraphQL guard from #391 and #444 refused mergePullRequest but not this mutation. Add it to the same pattern and refuse it with the merge message, for inline queries, -F query=@file and --input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
enablePullRequestAutoMergeto the GraphQL mutation guard inbash/gh-wrapper.sh.Auto-merge lets a PR merge later without the merge-lock or pre-merge review, so it is refused with the same message as
mergePullRequest. It is read from inline fields,-F query=@fileand--input, like the #445 merge cases.Tests: three new cases per mode in
bash/tests/test-gh-wrapper-off-org-guards.sh. They fail on origin/main (6 failures) and pass with the change.gh pr merge --autois unchanged: the wrapper treats--autoas a plain boolean flag onpr merge, so it already runspre-merge-review.shand its merge-lock check.