Skip to content

Wherein file fix #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ascrevia wants to merge 3 commits into from
Closed

Wherein file fix #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfb0e4e
Fix null contentType error
nzsakib Dec 11, 2025
9797e56
Merge remote-tracking branch 'upstream/master' into clickhouse-fix
uksarkar Jul 18, 2026
e1c8272
feat: add WhereInFile support to streamRead and selectGenerator methods
Crevia Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,12 +422,12 @@ public function readWithParams(Stream $streamRead, string $sql, array $params, a
* @param array $querySettings Per-query settings override
* @return \Generator yields associative arrays, one per row
*/
public function selectGenerator(string $sql, array $bindings = [], array $querySettings = []): \Generator
public function selectGenerator(string $sql, array $bindings = [], array $querySettings = [], ?WhereInFile $whereInFile = null): \Generator
{
$stream = fopen('php://temp', 'r+');
$streamRead = new Transport\StreamRead($stream);

$this->transport()->streamRead($streamRead, $sql . ' FORMAT JSONEachRow', $bindings, $querySettings);
$this->transport()->streamRead($streamRead, $sql . ' FORMAT JSONEachRow', $bindings, $querySettings, $whereInFile);

rewind($stream);

Expand Down
4 changes: 2 additions & 2 deletions src/Transport/Http.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,10 +973,10 @@ private function streaming(Stream $streamRW, CurlerRequest $request): Statement
* @return Statement
* @throws \ClickHouseDB\Exception\TransportException
*/
public function streamRead(Stream $streamRead, $sql, $bindings = [], array $querySettings = []): Statement
public function streamRead(Stream $streamRead, $sql, $bindings = [], array $querySettings = [], ?WhereInFile $whereInFile = null): Statement
{
$sql = $this->prepareQuery($sql, $bindings);
$request = $this->getRequestRead($sql, null, null, $querySettings);
$request = $this->getRequestRead($sql, $whereInFile, null, $querySettings);
return $this->streaming($streamRead, $request);

}
Expand Down