Add config file support for config resolution#729
Open
ubaskota wants to merge 3 commits into
Open
Conversation
SamRemis
reviewed
Jun 29, 2026
SamRemis
requested changes
Jul 7, 2026
| from smithy_aws_core.config.exceptions import ConfigParseError | ||
|
|
||
| # Type aliases | ||
| type PropertyValue = str | dict[str, str] |
Contributor
There was a problem hiding this comment.
[Discussion]
Instead of having ProfileProperties, a ProfileMap could have a Profile; each Profile could have ScalarProperties and GroupedProperties. The union feels a bit awkward to have to consider while coding around the StandardizedOutput object.
What do you think?
SamRemis
approved these changes
Jul 10, 2026
SamRemis
requested changes
Jul 10, 2026
SamRemis
left a comment
SamRemis
left a comment
Contributor
There was a problem hiding this comment.
My bad, clicked approve by mistake. Only the test comments are blocking
ubaskota
force-pushed
the
config_file_support
branch
from
July 11, 2026 21:04
cb70998 to
27cbdd5
Compare
ubaskota
changed the base branch from
develop
to
config_integration_implementation
July 11, 2026 21:20
SamRemis
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add support for parsing and merging AWS config and credentials files (
~/.aws/configand~/.aws/credentials) as part of the config resolution pipeline.Changes:
profiles/sso-sessions/services
ParsedConfigFileclass for querying the merged resultconfig-file-parser-tests.jsonandconfig-file-location-tests.json)+ unit tests for the query layer and file I/O edge casesTesting:
~/.aws/configfile to verify end-to-end parsing behaviorBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.