Repository navigation
Fix crash when leaving the app while a menu label scrolls - #49
Open
YoruDev-Ryland wants to merge 1 commit into
Open
YoruDev-Ryland wants to merge 1 commit into
YoruDev-Ryland wants to merge 1 commit into
Conversation
DsFolderButton.Glide looped an overflowing label's animation in an async void until the button was deselected. Leaving the app with a menu entry scrolling disposed the window's services; the next TranslateToAsync threw ObjectDisposedException out of the async void and crashed PKForge (seen on an AYN Odin 3, reproduced on the emulator). The loop now ends when the label leaves the screen and treats a disposed window as the end of the animation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DsFolderButton.Glideanimates a long menu label in anasync voidloop. If you leave the app while it runs, Android disposes the window, the nextTranslateToAsyncthrowsObjectDisposedException, and the app crashes.The loop now stops once the label is detached, and a disposed window ends the animation instead of throwing.
To reproduce: select a menu entry whose text scrolls, press Home, wait a few seconds, reopen the app. Before this change it crashes. After, it resumes normally. Tested on an AYN Odin 3 and the emulator.